Upper control arm, can I check these rather than buy new ones first,?

What makes you think they are bad? How did you decide on them being bad.

I had a banging noise from the right front side, I replaced the Tie bar ( drag link) the right hand side outer and inner tie rods and the right shock absorber and lower bracket, The garage said the shock absorber was completely seized and the noise was 90% solved, however I still have a knock at times. from that area when I go over slight bumps ( I also fitted new rubber spring Insulators top and bottom on that side, ( The garage will be starting on the left shock absorber next week ( but not the rubber insulators as they broke their spring compressor on my other ( right Front ) spring. I simply cant think of anything else, the only link I could imagine is that somehow the engine/ gearbox mounts are too complessed ( and too low)?? Neil

You are on the right track. old, worn motor mounts can cause a clank but I would first look at ALL the rubber bushings on the front end. I changed all of mine a couple of years ago and all the clunks dissappeared.